Chromium Code Reviews Chromium Code Reviews
Issue
1233953004:
Deduplicate typefaces across sub-pictures (Closed)
DescriptionDeduplicate typefaces across sub-pictures
Old flow to serialize a picture:
1) serialize picture ops
2) serialize all sub pictures recursively
3) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go
4) serialize the factories and typefaces
5) serialize the bytes from 3)
This allows the data in step 5) to refer to the deduplicated factories and typefaces from step 4). But, each sub picture in step 2) is completely siloed, so they can't dedup with the parent picture or each other.
New flow:
1) serialize picture ops
2) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go
3) dummy-serialize sub pictures into /dev/null, with the effect of adding any new typefaces to our dedup set
4) serialize the factories and typefaces
5) serialize the bytes from 2)
6) serialize all sub pictures recursively, with perfect deduplication because of step 3).
Now all typefaces in the top-level picture and all sub pictures recursively should end up deduplicated in the top-level typeface set.
Decoding changes are similar: we just thread through the top-level typefaces to the sub pictures. What's convenient / surprising is that this new code correctly reads old pictures if we just have each picture prefer its local typeface set over the top-level one: old pictures always just use their own typefaces, and new pictures always use the top-level ones.
BUG=skia:4092
Committed: https://skia.googlesource.com/skia/+/0c263fa9f80b9a20b6f6161a2e9a263c2c586a9b
Patch Set 1 #Patch Set 2 : more hacking #Patch Set 3 : working? #Patch Set 4 : rebase #
Messages
Total messages: 17 (7 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
