Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1233923004: Removing GrTemplates.h (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@grfontscaler
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrFontScaler.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrRectBatch.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
D src/gpu/GrTemplates.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
joshualitt
ptal, after discussing things with Mike, it doesn't seem like the union technique guarantees against ...
5 years, 5 months ago (2015-07-14 13:54:16 UTC) #2
robertphillips
lgtm
5 years, 5 months ago (2015-07-14 13:59:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233923004/1
5 years, 5 months ago (2015-07-17 13:22:07 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 13:40:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ec0d4342d248f0d53f527fb3e461a00eaa0c283

Powered by Google App Engine
This is Rietveld 408576698