Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233913010: Make root entry undeletable. (Closed)

Created:
5 years, 5 months ago by yawano
Modified:
5 years, 5 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make root entry undeletable. BUG=509483 TEST=manually tested. Right click the drive root and confirm that delete item does not appear. Committed: https://crrev.com/67e338e844c6e8ae198011eae8c82c0f9e7ad61f Cr-Commit-Position: refs/heads/master@{#339835}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hide command when entries is empty. #

Patch Set 3 : Revert patch set 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 2 2 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
@mtomasz: PTAL. Thank you!
5 years, 5 months ago (2015-07-17 01:16:24 UTC) #2
mtomasz
lgtm with a question. thanks! https://codereview.chromium.org/1233913010/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1233913010/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode696 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:696: event.canExecute = entries.length > ...
5 years, 5 months ago (2015-07-17 01:25:01 UTC) #3
yawano
https://codereview.chromium.org/1233913010/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1233913010/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode696 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:696: event.canExecute = entries.length > 0 && Since we show ...
5 years, 5 months ago (2015-07-21 01:26:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233913010/40001
5 years, 5 months ago (2015-07-22 04:04:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-22 04:38:59 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 04:39:38 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/67e338e844c6e8ae198011eae8c82c0f9e7ad61f
Cr-Commit-Position: refs/heads/master@{#339835}

Powered by Google App Engine
This is Rietveld 408576698