Issue 1233913008: Split off ParserBase into src/parser-base.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233913008: Split off ParserBase into src/parser-base.h (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg

Modified:
5 years ago

Reviewers:
adamk, rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Split off ParserBase into src/parser-base.h Previously, the PreParser and ParserBase (used by both the preparser and the parser) where in the same file. Splitting them into separate files makes the code easier to navigate. R=adamk

Patch Set 1 #

Patch Set 2 : Copy whole ParserBase, not just the class #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3977 lines)			Patch
M	src/parser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	src/parser-base.h	View	1	4 chunks	+5 lines, -1043 lines	0 comments	Download
M	src/preparser.h	View	1	3 chunks	+1 line, -2933 lines	0 comments	Download
M	src/preparser.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

adamk

As discussed in person this seems reasonable to me, but I'd like rossberg's sign-off as ...

5 years, 5 months ago (2015-07-16 22:31:53 UTC) #3

rossberg

5 years, 5 months ago (2015-07-17 08:18:02 UTC) #4

On 2015/07/16 22:31:53, adamk wrote:
> As discussed in person this seems reasonable to me, but I'd like rossberg's
> sign-off as well.

Definitely LGTM from me, this should have happened long ago.

You might want to give a heads-up on v8-team-harmony first, though, so that
people with open parser CLs have time to land.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages