Do not update pepper_flash component if there is not a newer version.

Do not update pepper_flash component if there is not a newer version.

If pepper_flash has not had a component update, then report current
version of component as the bundled version of Flash. This avoids a
redundant update of pepper_flash component if it doesn't need updating.

BUG=510289
TEST=Install Chrome, go to chrome://components and check that version of pepper_flash component is same as bundled Flash.

Committed: https://crrev.com/c6a4c3d92cffa472b4dda5a3192be13b4dcac6a7
Cr-Commit-Position: refs/heads/master@{#339333}

[Will Harris, 2015-07-16 21:08:54]

wfh@chromium.org changed reviewers:
+ sorin@chromium.org

[Will Harris, 2015-07-16 21:09:28]

I also manually tested setting an older version of Flash as bundled, and
checking the component correctly gets updated.

PTAL.

[Sorin Jianu, 2015-07-16 22:02:33]

Thank you Will, please update the CL as discussed.

[Will Harris, 2015-07-17 18:50:08]

PTAL

[Sorin Jianu, 2015-07-17 19:17:26]

lgtm

Thank you Will!

https://codereview.chromium.org/1233913005/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1233913005/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:295: // If
a version of Flash is bundled with Chrome, and it's a higher than the
possible typos here, consider "it's higher than" or "it's a higher version than"

[Will Harris, 2015-07-17 19:38:58]

thanks for the review

https://codereview.chromium.org/1233913005/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1233913005/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:295: // If
a version of Flash is bundled with Chrome, and it's a higher than the
On 2015/07/17 19:17:25, Sorin Jianu wrote:
> possible typos here, consider "it's higher than" or "it's a higher version
than"

Done. Also it seems convention is to do < 0 rather than == -1 so changed that.

[Will Harris, 2015-07-17 19:39:32]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-07-17 19:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/1233913005/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2015-07-17 19:41:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1233913005/40001

[commit-bot: I haz the power, 2015-07-17 21:29:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-17 21:30:08]

Patchset 3 (id:??) landed as
https://crrev.com/c6a4c3d92cffa472b4dda5a3192be13b4dcac6a7
Cr-Commit-Position: refs/heads/master@{#339333}