Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/usrsctp/BUILD.gn

Issue 1233913002: Refactor incompatible pointer type to a config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added mipsel clause back Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/gles2_conform_support/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/usrsctp/BUILD.gn
diff --git a/third_party/usrsctp/BUILD.gn b/third_party/usrsctp/BUILD.gn
index 7627c95c9c834f364f534294a359e64c2b2dff7b..76e47ca9e3b801c8204b9ecf627e74ca5fb6c51e 100644
--- a/third_party/usrsctp/BUILD.gn
+++ b/third_party/usrsctp/BUILD.gn
@@ -86,6 +86,7 @@ static_library("usrsctp") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ "//build/config/compiler:no_incompatible_pointer_warnings" ]
public_configs = [ ":usrsctp_config" ]
@@ -121,15 +122,6 @@ static_library("usrsctp") {
defines += [ "NON_WINDOWS_DEFINE" ]
}
- if (is_clang) {
- cflags = [ "-Wno-incompatible-pointer-types" ]
- } else if (target_cpu == "mipsel") {
- # mipsel is still using gcc (4.9),
- # which does not support "-Wno-incompatible-pointer-types"
- # so let's disable all warnings for this module.
- cflags = [ "-w" ]
- }
-
deps = [
"//crypto:platform",
]
« no previous file with comments | « gpu/gles2_conform_support/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698