Refactor incompatible pointer type to a config

build/config/compiler/BUILD.gn

Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 2c0b455add3903beeaa90c391e9e26ecc1e4299d..c02e3e7dc65035aa40091548981af94a7755e8c0 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1065,6 +1065,21 @@ config("no_size_t_to_int_warning") {
   }
 }
 
+# Some code presumes that pointers to structures/objects are compatible
+# regardless of whether what they point to is already known to be valid.
+# gcc 4.9 and earlier had no way of suppressing this warning without
+# supressing the rest of them.  Here we centralize the identification of
+# the gcc 4.9 toolchains.
+config("no_incompatible_pointer_warnings") {
+  cflags = []
+  if (is_chromeos && current_cpu == "arm") {
+    #cflags -= [ "-Werror", "-Wall" ]

[Sam Clegg, 2015/07/15 17:40:20]

Remove this comment?

[Peter Mayo, 2015/07/15 18:09:37]

Done.

+    cflags += [ "-w" ]
+  } else if (is_clang) {

[Sam Clegg, 2015/07/15 17:40:20]

Wouldn't it make sense for check for is_clang condition first, in case chromeos
switch to using clang for their arm build?

[Peter Mayo, 2015/07/15 18:09:37]

Done.

+    cflags += [ "-Wno-incompatible-pointer-types" ]
+  }
+}
+
 # Optimization -----------------------------------------------------------------
 #
 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config"