Refactor incompatible pointer type to a config

third_party/usrsctp/BUILD.gn

Index: third_party/usrsctp/BUILD.gn
diff --git a/third_party/usrsctp/BUILD.gn b/third_party/usrsctp/BUILD.gn
index 7627c95c9c834f364f534294a359e64c2b2dff7b..76e47ca9e3b801c8204b9ecf627e74ca5fb6c51e 100644
--- a/third_party/usrsctp/BUILD.gn
+++ b/third_party/usrsctp/BUILD.gn
@@ -86,6 +86,7 @@ static_library("usrsctp") {
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
+  configs += [ "//build/config/compiler:no_incompatible_pointer_warnings" ]
 
   public_configs = [ ":usrsctp_config" ]
 
@@ -121,15 +122,6 @@ static_library("usrsctp") {
     defines += [ "NON_WINDOWS_DEFINE" ]
   }
 
-  if (is_clang) {
-    cflags = [ "-Wno-incompatible-pointer-types" ]
-  } else if (target_cpu == "mipsel") {
-    # mipsel is still using gcc (4.9),
-    # which does not support "-Wno-incompatible-pointer-types"
-    # so let's disable all warnings for this module.
-    cflags = [ "-w" ]

[Dirk Pranke, 2015/07/13 23:08:04]

Do we need this block somewhere in the generic config?

[Peter Mayo, 2015/07/14 14:10:30]

I hope not.

It seems pretty terrible to turn all warnings off in general, and the comment
leads me to believe it is only necessary because of the incompatible pointers. 
For the time being this change doesn't increase the chance of rot, since it will
still get the flag from the config.  Any changes that tighten up that change
will expose any rot in this config similarly to fixing it here.

[Dirk Pranke, 2015/07/14 15:54:14]

I think I phrased this badly; my concern was actually that  I didn't see
anything that would offset this deletion, so won't we this cause a problem on a
non-CrOS mipsel build after this is deleted?

-  }
-
   deps = [
     "//crypto:platform",
   ]