Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1233913002: Refactor incompatible pointer type to a config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added mipsel clause back Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/secondary/third_party/nss/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 1040 matching lines...) Expand 10 before | Expand all | Expand 10 after
1051 # Note that this can be applied regardless of platform and architecture to 1051 # Note that this can be applied regardless of platform and architecture to
1052 # clean up the call sites. This will only apply the flag when necessary. 1052 # clean up the call sites. This will only apply the flag when necessary.
1053 # 1053 #
1054 # TODO(jschuh): crbug.com/167187 fix this and delete this config. 1054 # TODO(jschuh): crbug.com/167187 fix this and delete this config.
1055 config("no_size_t_to_int_warning") { 1055 config("no_size_t_to_int_warning") {
1056 if (is_win && current_cpu == "x64") { 1056 if (is_win && current_cpu == "x64") {
1057 cflags = [ "/wd4267" ] 1057 cflags = [ "/wd4267" ]
1058 } 1058 }
1059 } 1059 }
1060 1060
1061 # Some code presumes that pointers to structures/objects are compatible
1062 # regardless of whether what they point to is already known to be valid.
1063 # gcc 4.9 and earlier had no way of suppressing this warning without
1064 # supressing the rest of them. Here we centralize the identification of
1065 # the gcc 4.9 toolchains.
1066 config("no_incompatible_pointer_warnings") {
1067 cflags = []
1068 if (is_clang) {
1069 cflags += [ "-Wno-incompatible-pointer-types" ]
1070 } else if (current_cpu == "mipsel") {
1071 cflags += [ "-w" ]
1072 } else if (is_chromeos && current_cpu == "arm") {
1073 cflags += [ "-w" ]
1074 }
1075 }
1076
1061 # Optimization ----------------------------------------------------------------- 1077 # Optimization -----------------------------------------------------------------
1062 # 1078 #
1063 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config" 1079 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config"
1064 # which it will assign to the config it implicitly applies to every target. If 1080 # which it will assign to the config it implicitly applies to every target. If
1065 # you want to override the optimization level for your target, remove this 1081 # you want to override the optimization level for your target, remove this
1066 # config (which will expand differently for debug or release builds), and then 1082 # config (which will expand differently for debug or release builds), and then
1067 # add back the one you want to override it with: 1083 # add back the one you want to override it with:
1068 # 1084 #
1069 # configs -= default_optimization_config 1085 # configs -= default_optimization_config
1070 # configs += [ "//build/config/compiler/optimize_max" ] 1086 # configs += [ "//build/config/compiler/optimize_max" ]
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 cflags += [ "-gsplit-dwarf" ] 1251 cflags += [ "-gsplit-dwarf" ]
1236 } 1252 }
1237 } 1253 }
1238 } 1254 }
1239 1255
1240 config("no_symbols") { 1256 config("no_symbols") {
1241 if (!is_win) { 1257 if (!is_win) {
1242 cflags = [ "-g0" ] 1258 cflags = [ "-g0" ]
1243 } 1259 }
1244 } 1260 }
OLDNEW
« no previous file with comments | « no previous file | build/secondary/third_party/nss/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698