Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1233903003: MIPS64: Fix string stubs. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix string stubs. An innocent-looking change in 'c63e50ed Reland Update V8 DEPS.' exposed latent bugs in SubStringStub and StringCharFromCodeGenerator. TEST=mjsunit/string-replace, msjunit/string-split, others.... BUG= Committed: https://crrev.com/88214f1bf8429311d26d8f85f2a1e4759cb3fe7e Cr-Commit-Position: refs/heads/master@{#29731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M src/mips64/code-stubs-mips64.cc View 3 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
paul.l...
PTAL.
5 years, 5 months ago (2015-07-17 03:54:29 UTC) #2
balazs.kilvady
LGTM.
5 years, 5 months ago (2015-07-17 09:15:22 UTC) #3
dusmil.imgtec
LGTM.
5 years, 5 months ago (2015-07-17 09:43:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233903003/1
5 years, 5 months ago (2015-07-17 13:24:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 13:56:50 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 13:57:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88214f1bf8429311d26d8f85f2a1e4759cb3fe7e
Cr-Commit-Position: refs/heads/master@{#29731}

Powered by Google App Engine
This is Rietveld 408576698