Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1233883005: Fix i18nTemplate.process() for DocumentFragments. (Closed)

Created:
5 years, 5 months ago by Dan Beam
Modified:
5 years, 5 months ago
Reviewers:
Jeremy Klein
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix i18nTemplate.process() for DocumentFragments. Also simplify process() by using ::shadow, which isn't a combinator (and therefore includes top-level elements). R=jlklein@chromium.org BUG=425626 Committed: https://crrev.com/fb05964faf913e285cca82d1500de978dafc9e04 Cr-Commit-Position: refs/heads/master@{#339372}

Patch Set 1 : mo #

Patch Set 2 : stronger typing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -61 lines) Patch
M chrome/test/data/webui/i18n_process_test.html View 1 4 chunks +38 lines, -6 lines 0 comments Download
M ui/webui/resources/css/i18n_process.css View 1 1 chunk +10 lines, -4 lines 0 comments Download
M ui/webui/resources/js/i18n_template_no_process.js View 1 6 chunks +54 lines, -51 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
Dan Beam
5 years, 5 months ago (2015-07-17 01:44:06 UTC) #2
Jeremy Klein
Have you tested this with multiple layers of shadow boundaries? ::shadow only pierces a single ...
5 years, 5 months ago (2015-07-17 17:21:05 UTC) #5
Jeremy Klein
lgtm verified offline
5 years, 5 months ago (2015-07-17 20:44:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233883005/110001
5 years, 5 months ago (2015-07-17 21:37:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/45885)
5 years, 5 months ago (2015-07-18 00:04:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233883005/110001
5 years, 5 months ago (2015-07-18 00:07:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:110001)
5 years, 5 months ago (2015-07-18 01:21:33 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-18 01:23:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb05964faf913e285cca82d1500de978dafc9e04
Cr-Commit-Position: refs/heads/master@{#339372}

Powered by Google App Engine
This is Rietveld 408576698