Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1233853004: Revert of Another trivial cleanup (Closed)

Created:
5 years, 5 months ago by joshualitt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Another trivial cleanup (patchset #6 id:100001 of https://codereview.chromium.org/1229303003/) Reason for revert: breaking things Original issue's description: > Another trivial cleanup > > TBR=bsalomon@google.com > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52e7657cd850f95e66eb23c6d138ee45149a1039 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6968428f44e8cc42edee7e3238b37e3b3a46106f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -56 lines) Patch
M gyp/gpu.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
A include/gpu/GrFragmentStage.h View 1 chunk +34 lines, -0 lines 0 comments Download
M include/gpu/GrPaint.h View 1 chunk +1 line, -1 line 0 comments Download
D include/gpu/GrStagedProcessor.h View 1 chunk +0 lines, -41 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrPendingFragmentStage.h View 1 chunk +53 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +10 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Another trivial cleanup
5 years, 5 months ago (2015-07-13 20:28:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233853004/1
5 years, 5 months ago (2015-07-13 20:29:04 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 20:29:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6968428f44e8cc42edee7e3238b37e3b3a46106f

Powered by Google App Engine
This is Rietveld 408576698