Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 123383002: Enable SDCH support over HTTPS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address codereview comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/sdch_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 7271cb814faaa0fb3d33d6db8e5671634bb5f5de..7eb772228166829ad6dbcfe69b39b61bfc15b341 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1388,13 +1388,20 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
browser_process_->intranet_redirect_detector();
GoogleSearchCounter::RegisterForNotifications();
- // Disable SDCH filtering if switches::kEnableSdch is 0.
- int sdch_enabled = 1;
if (parsed_command_line().HasSwitch(switches::kEnableSdch)) {
- base::StringToInt(parsed_command_line().GetSwitchValueASCII(
- switches::kEnableSdch), &sdch_enabled);
- if (!sdch_enabled)
- net::SdchManager::EnableSdchSupport(false);
+ // SDCH options via switches::kEnableSdch include:
+ const int kSdchDisabled = 0;
+ const int kSdchOverHttpEnabled = 1;
+ const int kSdchOverBothHttpAndHttpsEnabled = 2;
+ int sdch_enabled = kSdchOverHttpEnabled;
+ if (base::StringToInt(parsed_command_line().GetSwitchValueASCII(
+ switches::kEnableSdch), &sdch_enabled)) {
+ if (sdch_enabled == kSdchDisabled) {
+ net::SdchManager::EnableSdchSupport(false);
+ } else if (sdch_enabled == kSdchOverBothHttpAndHttpsEnabled) {
+ net::SdchManager::EnableSecureSchemeSupport(true);
+ }
+ }
}
if (parsed_command_line().HasSwitch(switches::kEnableWatchdog))
« no previous file with comments | « no previous file | net/base/sdch_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698