Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1233823002: X87: Debugger: use debug break slot to break on call. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Debugger: use debug break slot to break on call. port 8965b683ce39bc3c24ed2466d189323d81a70852 (r29561) original commit message: Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. BUG= Committed: https://crrev.com/a5458c922102eb477c68953ce15a804968d64f44 Cr-Commit-Position: refs/heads/master@{#29630}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -81 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/debug-x87.cc View 7 chunks +6 lines, -76 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-14 01:53:08 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 02:09:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233823002/20001
5 years, 5 months ago (2015-07-14 02:09:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-14 02:34:39 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:34:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5458c922102eb477c68953ce15a804968d64f44
Cr-Commit-Position: refs/heads/master@{#29630}

Powered by Google App Engine
This is Rietveld 408576698