Issue 12338002: Forced inlining of some GC-related methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12338002: Forced inlining of some GC-related methods. (Closed)

Created:
7 years, 10 months ago by Sven Panne

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Forced inlining of some GC-related methods. The selection of methods were driven by GCC's -Winline plus some benchmarking. On ia32, the additional amount of code is roughly 63kB (= 0.07% of Chrome ;-). BUG=v8:1607 Committed: http://code.google.com/p/v8/source/detail?r=13710

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	src/heap.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.h	View	7 chunks	+21 lines, -21 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, if it helps performance and doesn't regress on mobile.

7 years, 10 months ago (2013-02-21 13:58:43 UTC) #2

Sven Panne

7 years, 10 months ago (2013-02-21 14:02:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13710 (presubmit successful).

Expand Messages | Collapse Messages