Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1233753002: Use permission_broker's OpenPath method to open HID devices. (Closed)

Created:
5 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 5 months ago
Reviewers:
rpaquay
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use permission_broker's OpenPath method to open HID devices. This new method allows Chrome to open device nodes without having to chmod them to a group of which Chrome is a member and allows the permission broker to set opens on the file descriptor before passing it to Chrome. This is a win for security and future extensibility. BUG=None Committed: https://crrev.com/e6aead1fa5623666c4e5cd78ce17e1935ee769b1 Cr-Commit-Position: refs/heads/master@{#338367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -44 lines) Patch
M device/hid/hid_service_linux.h View 2 chunks +13 lines, -5 lines 0 comments Download
M device/hid/hid_service_linux.cc View 4 chunks +52 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
5 years, 5 months ago (2015-07-10 20:17:44 UTC) #2
rpaquay
lgtm
5 years, 5 months ago (2015-07-10 21:27:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233753002/1
5 years, 5 months ago (2015-07-10 21:30:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 21:36:22 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:37:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6aead1fa5623666c4e5cd78ce17e1935ee769b1
Cr-Commit-Position: refs/heads/master@{#338367}

Powered by Google App Engine
This is Rietveld 408576698