Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233703003: add initState, rename animated_container (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add new initState method to widget, rename animated_container to animation_builder and refactor it. This fixes the background color of the settings page. R=abarth@chromium.org, abarth, mpcomplete Committed: https://chromium.googlesource.com/external/mojo/+/edbf25a7560cc4a98aa0aa87dfc6b9a6ebda8a1e

Patch Set 1 #

Patch Set 2 : update classes to use initState #

Patch Set 3 : rebase #

Patch Set 4 : remove print statement #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -62 lines) Patch
M sky/sdk/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/fitness/lib/home.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M sky/sdk/example/fitness/lib/main.dart View 1 2 chunks +4 lines, -1 line 1 comment Download
M sky/sdk/example/stocks/lib/main.dart View 1 2 chunks +4 lines, -1 line 1 comment Download
M sky/sdk/example/stocks/lib/stock_home.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_settings.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/widgets/card_collection.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/editing/input.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M sky/sdk/lib/widgets/README.md View 2 chunks +17 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/animated_container.dart View 2 chunks +6 lines, -6 lines 0 comments Download
A + sky/sdk/lib/widgets/animation_builder.dart View 2 chunks +12 lines, -11 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/material.dart View 3 chunks +31 lines, -16 lines 1 comment Download
M sky/sdk/lib/widgets/scrollable.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1233703003/diff/60001/sky/sdk/example/fitness/lib/main.dart File sky/sdk/example/fitness/lib/main.dart (right): https://codereview.chromium.org/1233703003/diff/60001/sky/sdk/example/fitness/lib/main.dart#newcode19 sky/sdk/example/fitness/lib/main.dart:19: FitnessApp(); You can remove this function given that ...
5 years, 5 months ago (2015-07-10 23:26:00 UTC) #2
jackson
Committed patchset #4 (id:60001) manually as edbf25a7560cc4a98aa0aa87dfc6b9a6ebda8a1e (presubmit successful).
5 years, 5 months ago (2015-07-10 23:27:21 UTC) #3
Matt Perry
5 years, 5 months ago (2015-07-13 17:37:45 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1233703003/diff/60001/sky/sdk/lib/widgets/mat...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1233703003/diff/60001/sky/sdk/lib/widgets/mat...
sky/sdk/lib/widgets/material.dart:67: );
It's unfortunate the amount of boilerplate this adds. The nice thing about
AnimationBuilder IMO was that it took care of animating/updating all its
variables behind the scenes. Now we have to (a) keep a copy of them on each
Widget and (b) tell AnimationBuilder which ones we want to update. It would be
nice if there were a way to keep the old automagic.

Powered by Google App Engine
This is Rietveld 408576698