Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: sky/sdk/example/rendering/sector_layout.dart

Issue 1233673003: Fix bugs found by Dart analyzer (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/example/raw/spinning_square.dart ('k') | sky/sdk/lib/mojo/asset_bundle.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/rendering/sector_layout.dart
diff --git a/sky/sdk/example/rendering/sector_layout.dart b/sky/sdk/example/rendering/sector_layout.dart
index 24f09b3b46f308ca76748beb8a50287a6dcc1fa1..52dd265b336c9a81c6d03e806e6114449cd600f5 100644
--- a/sky/sdk/example/rendering/sector_layout.dart
+++ b/sky/sdk/example/rendering/sector_layout.dart
@@ -98,6 +98,8 @@ abstract class RenderSector extends RenderObject {
assert(sizedByParent);
}
+ Rect get paintBounds => new Rect.fromLTWH(0.0, 0.0, 2.0 * deltaRadius, 2.0 * deltaRadius);
Hixie 2015/07/10 18:01:01 this seems wrong. the origin is on the middle of t
abarth-chromium 2015/07/10 18:09:30 Ok. Currently it's not used by anything because n
+
bool hitTest(HitTestResult result, { double radius, double theta }) {
assert(parentData is SectorParentData);
if (radius < parentData.radius || radius >= parentData.radius + deltaRadius ||
@@ -492,7 +494,7 @@ class RenderBoxToRenderSectorAdapter extends RenderBox {
result.add(new BoxHitTestEntry(this, position));
return true;
}
-
+
}
class RenderSolidColor extends RenderDecoratedSector {
« no previous file with comments | « sky/sdk/example/raw/spinning_square.dart ('k') | sky/sdk/lib/mojo/asset_bundle.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698