Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6648)

Unified Diff: chrome/test/base/testing_profile.cc

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix "gn check" and compilation on Mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/bookmarks.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index c1badfb49a63af99ddfeeec4012cf863bc9db347..976c7a8bcd990e5367faaabd36bdd71203b2e68f 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"
+#include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/favicon/chrome_fallback_icon_client_factory.h"
@@ -210,7 +211,7 @@ scoped_ptr<KeyedService> BuildInMemoryURLIndex(
}
scoped_ptr<KeyedService> BuildBookmarkModel(content::BrowserContext* context) {
- Profile* profile = static_cast<Profile*>(context);
+ Profile* profile = Profile::FromBrowserContext(context);
ChromeBookmarkClient* bookmark_client =
ChromeBookmarkClientFactory::GetForProfile(profile);
scoped_ptr<BookmarkModel> bookmark_model(new BookmarkModel(bookmark_client));
@@ -224,12 +225,6 @@ scoped_ptr<KeyedService> BuildBookmarkModel(content::BrowserContext* context) {
return bookmark_model.Pass();
}
-scoped_ptr<KeyedService> BuildChromeBookmarkClient(
- content::BrowserContext* context) {
- return make_scoped_ptr(
- new ChromeBookmarkClient(static_cast<Profile*>(context)));
-}
-
void TestProfileErrorCallback(WebDataServiceWrapper::ErrorType error_type,
sql::InitStatus status) {
NOTREACHED();
@@ -592,8 +587,10 @@ void TestingProfile::CreateBookmarkModel(bool delete_file) {
base::FilePath path = GetPath().Append(bookmarks::kBookmarksFileName);
base::DeleteFile(path, false);
}
+ ManagedBookmarkServiceFactory::GetInstance()->SetTestingFactory(
+ this, ManagedBookmarkServiceFactory::GetDefaultFactory());
ChromeBookmarkClientFactory::GetInstance()->SetTestingFactory(
- this, BuildChromeBookmarkClient);
+ this, ChromeBookmarkClientFactory::GetDefaultFactory());
// This creates the BookmarkModel.
ignore_result(BookmarkModelFactory::GetInstance()->SetTestingFactoryAndUse(
this, BuildBookmarkModel));
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/bookmarks.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698