Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix "gn check" and compilation on Mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
index 708ae7181668ae5ce0ae590317ecac757e8bb6c5..1650def8af51cc2f067caa7072dd1dc3709ff31b 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
@@ -9,13 +9,13 @@
#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"
-class ChromeBookmarkClient;
@class BookmarkBubbleController;
@class BookmarkSyncPromoController;
namespace bookmarks {
class BookmarkModel;
class BookmarkNode;
+class ManagedBookmarkService;
}
// Controller for the bookmark bubble. The bookmark bubble is a
@@ -24,9 +24,9 @@ class BookmarkNode;
// the bookmark in various ways (name, folder, etc.)
@interface BookmarkBubbleController : BaseBubbleController {
@private
- // |client_|, |model_| and |node_| are weak and owned by the current browser's
- // profile.
- ChromeBookmarkClient* client_; // weak
+ // |managed_|, |model_| and |node_| are weak and owned by the current
+ // browser's profile.
+ bookmarks::ManagedBookmarkService* managedBookmarkService_; // weak
bookmarks::BookmarkModel* model_; // weak
const bookmarks::BookmarkNode* node_; // weak
@@ -56,7 +56,7 @@ class BookmarkNode;
// it desires it to be visible on the screen. It is not shown by the
// init routine. Closing of the window happens implicitly on dealloc.
- (id)initWithParentWindow:(NSWindow*)parentWindow
- client:(ChromeBookmarkClient*)client
+ managed:(bookmarks::ManagedBookmarkService*)managed
model:(bookmarks::BookmarkModel*)model
node:(const bookmarks::BookmarkNode*)node
alreadyBookmarked:(BOOL)alreadyBookmarked;

Powered by Google App Engine
This is Rietveld 408576698