Fix componentization of chrome/browser/bookmarks

chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h

Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
index e12850114ae2df565c06836fd80175b487567e22..ec040fce15dc8b833e4c80cca93229f69f87bfdd 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
@@ -11,11 +11,10 @@
 #include "base/basictypes.h"
 #include "chrome/common/extensions/api/bookmarks.h"
 
-class ChromeBookmarkClient;
-
 namespace bookmarks {
 class BookmarkModel;
 class BookmarkNode;
+class ManagedBookmarkService;
 }
 
 // Helper functions.
@@ -24,25 +23,25 @@ namespace bookmark_api_helpers {
 
 // The returned value is owned by the caller.
 api::bookmarks::BookmarkTreeNode* GetBookmarkTreeNode(
-    ChromeBookmarkClient* client,
+    bookmarks::ManagedBookmarkService* managed,
     const bookmarks::BookmarkNode* node,
     bool recurse,
     bool only_folders);
 
 // Add a JSON representation of |node| to the JSON |nodes|.
-void AddNode(ChromeBookmarkClient* client,
+void AddNode(bookmarks::ManagedBookmarkService* managed,
              const bookmarks::BookmarkNode* node,
              std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode> >* nodes,
              bool recurse);
 
-void AddNodeFoldersOnly(ChromeBookmarkClient* client,
-                        const bookmarks::BookmarkNode* node,
-                        std::vector<linked_ptr<
-                            api::bookmarks::BookmarkTreeNode> >* nodes,
-                        bool recurse);
+void AddNodeFoldersOnly(

[sky, 2015/07/20 15:53:19]

How about a description?

[sdefresne, 2015/07/20 17:43:40]

I only changed the first parameter of this method to be a ManagedBookmarkService
instead of a ChromeBookmarkClient, I may not be the most qualified person to add
a description. I've tried to add one, but not sure if it is correct.

[sky, 2015/07/20 20:10:56]

I realize you only change the args. Feel free to remove your comment and we'll
get someone else to add one at a later date.

+    bookmarks::ManagedBookmarkService* managed,
+    const bookmarks::BookmarkNode* node,
+    std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode>>* nodes,
+    bool recurse);
 
 bool RemoveNode(bookmarks::BookmarkModel* model,
-                ChromeBookmarkClient* client,
+                bookmarks::ManagedBookmarkService* managed,
                 int64 id,
                 bool recursive,
                 std::string* error);