Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/bookmarks/bookmark_model_factory.cc

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model_factory.cc
diff --git a/chrome/browser/bookmarks/bookmark_model_factory.cc b/chrome/browser/bookmarks/bookmark_model_factory.cc
index 208bb143dff99abb0ad2d669e185b35cd0e919a1..55044cac41563d44ea9bb6e581a10f1ec5efa581 100644
--- a/chrome/browser/bookmarks/bookmark_model_factory.cc
+++ b/chrome/browser/bookmarks/bookmark_model_factory.cc
@@ -21,7 +21,6 @@
#include "components/bookmarks/browser/startup_task_runner_service.h"
#include "components/bookmarks/common/bookmark_pref_names.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
-#include "components/pref_registry/pref_registry_syncable.h"
#include "components/undo/bookmark_undo_service.h"
#include "content/public/browser/browser_thread.h"
@@ -83,14 +82,7 @@ KeyedService* BookmarkModelFactory::BuildServiceInstanceFor(
void BookmarkModelFactory::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
- // Don't sync this, as otherwise, due to a limitation in sync, it
- // will cause a deadlock (see http://crbug.com/97955). If we truly
- // want to sync the expanded state of folders, it should be part of
- // bookmark sync itself (i.e., a property of the sync folder nodes).
- registry->RegisterListPref(bookmarks::prefs::kBookmarkEditorExpandedNodes,
- new base::ListValue);
- registry->RegisterListPref(bookmarks::prefs::kManagedBookmarks);
- registry->RegisterListPref(bookmarks::prefs::kSupervisedBookmarks);
+ BookmarkModel::RegisterProfilePrefs(registry);
}
content::BrowserContext* BookmarkModelFactory::GetBrowserContextToUse(

Powered by Google App Engine
This is Rietveld 408576698