Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: components/bookmarks.gypi

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix "gn check" and compilation on Mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/bookmarks/managed/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/bookmarks/browser 8 # GN version: //components/bookmarks/browser
9 'target_name': 'bookmarks_browser', 9 'target_name': 'bookmarks_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 { 105 {
106 # GN version: //components/bookmarks/managed 106 # GN version: //components/bookmarks/managed
107 'target_name': 'bookmarks_managed', 107 'target_name': 'bookmarks_managed',
108 'type': 'static_library', 108 'type': 'static_library',
109 'include_dirs': [ 109 'include_dirs': [
110 '..', 110 '..',
111 ], 111 ],
112 'dependencies': [ 112 'dependencies': [
113 'bookmarks_browser', 113 'bookmarks_browser',
114 'components_strings.gyp:components_strings', 114 'components_strings.gyp:components_strings',
115 'keyed_service_core',
115 ], 116 ],
116 'sources': [ 117 'sources': [
118 'bookmarks/managed/managed_bookmark_service.cc',
119 'bookmarks/managed/managed_bookmark_service.h',
117 'bookmarks/managed/managed_bookmarks_tracker.cc', 120 'bookmarks/managed/managed_bookmarks_tracker.cc',
118 'bookmarks/managed/managed_bookmarks_tracker.h', 121 'bookmarks/managed/managed_bookmarks_tracker.h',
119 ], 122 ],
120 }, 123 },
121 { 124 {
122 # GN version: //components/bookmarks/test 125 # GN version: //components/bookmarks/test
123 'target_name': 'bookmarks_test_support', 126 'target_name': 'bookmarks_test_support',
124 'type': 'static_library', 127 'type': 'static_library',
125 'include_dirs': [ 128 'include_dirs': [
126 '..', 129 '..',
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 'type': 'none', 186 'type': 'none',
184 'variables': { 187 'variables': {
185 'source_file': 'bookmarks/common/android/bookmark_type.h', 188 'source_file': 'bookmarks/common/android/bookmark_type.h',
186 }, 189 },
187 'includes': [ '../build/android/java_cpp_enum.gypi' ], 190 'includes': [ '../build/android/java_cpp_enum.gypi' ],
188 }, 191 },
189 ], 192 ],
190 }] 193 }]
191 ], 194 ],
192 } 195 }
OLDNEW
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/bookmarks/managed/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698