Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix "gn check" and compilation on Mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h" 5 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
11 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 11 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
12 #include "chrome/browser/bookmarks/chrome_bookmark_client.h" 12 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
13 #include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"
14 #include "chrome/browser/prefs/incognito_mode_prefs.h" 13 #include "chrome/browser/prefs/incognito_mode_prefs.h"
15 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ui/bookmarks/bookmark_editor.h" 15 #include "chrome/browser/ui/bookmarks/bookmark_editor.h"
17 #include "chrome/browser/ui/bookmarks/bookmark_utils.h" 16 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
18 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
19 #include "chrome/browser/ui/chrome_pages.h" 18 #include "chrome/browser/ui/chrome_pages.h"
20 #include "chrome/browser/ui/tabs/tab_strip_model.h" 19 #include "chrome/browser/ui/tabs/tab_strip_model.h"
21 #include "chrome/browser/undo/bookmark_undo_service_factory.h" 20 #include "chrome/browser/undo/bookmark_undo_service_factory.h"
22 #include "chrome/common/chrome_switches.h" 21 #include "chrome/common/chrome_switches.h"
23 #include "chrome/common/pref_names.h" 22 #include "chrome/common/pref_names.h"
24 #include "chrome/grit/generated_resources.h" 23 #include "chrome/grit/generated_resources.h"
25 #include "components/bookmarks/browser/bookmark_client.h" 24 #include "components/bookmarks/browser/bookmark_client.h"
26 #include "components/bookmarks/browser/bookmark_model.h" 25 #include "components/bookmarks/browser/bookmark_model.h"
27 #include "components/bookmarks/browser/bookmark_utils.h" 26 #include "components/bookmarks/browser/bookmark_utils.h"
27 #include "components/bookmarks/managed/managed_bookmark_service.h"
28 #include "components/undo/bookmark_undo_service.h" 28 #include "components/undo/bookmark_undo_service.h"
29 #include "content/public/browser/page_navigator.h" 29 #include "content/public/browser/page_navigator.h"
30 #include "content/public/browser/user_metrics.h" 30 #include "content/public/browser/user_metrics.h"
31 #include "grit/components_strings.h" 31 #include "grit/components_strings.h"
32 #include "ui/base/l10n/l10n_util.h" 32 #include "ui/base/l10n/l10n_util.h"
33 33
34 using base::UserMetricsAction; 34 using base::UserMetricsAction;
35 using bookmarks::BookmarkNode; 35 using bookmarks::BookmarkNode;
36 using content::PageNavigator; 36 using content::PageNavigator;
37 37
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 int command_id) const { 313 int command_id) const {
314 if (command_id == IDC_BOOKMARK_BAR_UNDO) { 314 if (command_id == IDC_BOOKMARK_BAR_UNDO) {
315 return BookmarkUndoServiceFactory::GetForProfile(profile_)-> 315 return BookmarkUndoServiceFactory::GetForProfile(profile_)->
316 undo_manager()->GetUndoLabel(); 316 undo_manager()->GetUndoLabel();
317 } 317 }
318 if (command_id == IDC_BOOKMARK_BAR_REDO) { 318 if (command_id == IDC_BOOKMARK_BAR_REDO) {
319 return BookmarkUndoServiceFactory::GetForProfile(profile_)-> 319 return BookmarkUndoServiceFactory::GetForProfile(profile_)->
320 undo_manager()->GetRedoLabel(); 320 undo_manager()->GetRedoLabel();
321 } 321 }
322 if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) { 322 if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) {
323 ChromeBookmarkClient* client = 323 bookmarks::ManagedBookmarkService* managed =
324 ChromeBookmarkClientFactory::GetForProfile(profile_); 324 ManagedBookmarkServiceFactory::GetForProfile(profile_);
325 return l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS, 325 return l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS,
326 client->managed_node()->GetTitle()); 326 managed->managed_node()->GetTitle());
327 } 327 }
328 328
329 NOTREACHED(); 329 NOTREACHED();
330 return base::string16(); 330 return base::string16();
331 } 331 }
332 332
333 bool BookmarkContextMenuController::IsCommandIdChecked(int command_id) const { 333 bool BookmarkContextMenuController::IsCommandIdChecked(int command_id) const {
334 PrefService* prefs = profile_->GetPrefs(); 334 PrefService* prefs = profile_->GetPrefs();
335 if (command_id == IDC_BOOKMARK_BAR_ALWAYS_SHOW) 335 if (command_id == IDC_BOOKMARK_BAR_ALWAYS_SHOW)
336 return prefs->GetBoolean(bookmarks::prefs::kShowBookmarkBar); 336 return prefs->GetBoolean(bookmarks::prefs::kShowBookmarkBar);
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 bookmarks::CanPasteFromClipboard(model_, selection_[0])) || 410 bookmarks::CanPasteFromClipboard(model_, selection_[0])) ||
411 bookmarks::CanPasteFromClipboard(model_, parent_)); 411 bookmarks::CanPasteFromClipboard(model_, parent_));
412 } 412 }
413 return true; 413 return true;
414 } 414 }
415 415
416 bool BookmarkContextMenuController::IsCommandIdVisible(int command_id) const { 416 bool BookmarkContextMenuController::IsCommandIdVisible(int command_id) const {
417 if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) { 417 if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) {
418 // The option to hide the Managed Bookmarks folder is only available if 418 // The option to hide the Managed Bookmarks folder is only available if
419 // there are any managed bookmarks configured at all. 419 // there are any managed bookmarks configured at all.
420 ChromeBookmarkClient* client = 420 bookmarks::ManagedBookmarkService* managed =
421 ChromeBookmarkClientFactory::GetForProfile(profile_); 421 ManagedBookmarkServiceFactory::GetForProfile(profile_);
422 return !client->managed_node()->empty(); 422 return !managed->managed_node()->empty();
423 } 423 }
424 424
425 return true; 425 return true;
426 } 426 }
427 427
428 bool BookmarkContextMenuController::GetAcceleratorForCommandId( 428 bool BookmarkContextMenuController::GetAcceleratorForCommandId(
429 int command_id, 429 int command_id,
430 ui::Accelerator* accelerator) { 430 ui::Accelerator* accelerator) {
431 return false; 431 return false;
432 } 432 }
433 433
434 void BookmarkContextMenuController::BookmarkModelChanged() { 434 void BookmarkContextMenuController::BookmarkModelChanged() {
435 if (delegate_) 435 if (delegate_)
436 delegate_->CloseMenu(); 436 delegate_->CloseMenu();
437 } 437 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/bookmarks_helper.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698