Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Side by Side Diff: components/bookmarks/browser/bookmark_model.h

Issue 1233673002: Fix componentization of chrome/browser/bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_ 5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_
6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_ 6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 21 matching lines...) Expand all
32 } 32 }
33 33
34 namespace favicon_base { 34 namespace favicon_base {
35 struct FaviconImageResult; 35 struct FaviconImageResult;
36 } 36 }
37 37
38 namespace query_parser { 38 namespace query_parser {
39 enum class MatchingAlgorithm; 39 enum class MatchingAlgorithm;
40 } 40 }
41 41
42 namespace user_prefs {
43 class PrefRegistrySyncable;
44 }
45
42 namespace bookmarks { 46 namespace bookmarks {
43 47
44 class BookmarkCodecTest; 48 class BookmarkCodecTest;
45 class BookmarkExpandedStateTracker; 49 class BookmarkExpandedStateTracker;
46 class BookmarkIndex; 50 class BookmarkIndex;
47 class BookmarkLoadDetails; 51 class BookmarkLoadDetails;
48 class BookmarkModelObserver; 52 class BookmarkModelObserver;
49 class BookmarkStorage; 53 class BookmarkStorage;
50 class ScopedGroupBookmarkActions; 54 class ScopedGroupBookmarkActions;
51 class TestBookmarkClient; 55 class TestBookmarkClient;
(...skipping 12 matching lines...) Expand all
64 class BookmarkModel : public KeyedService { 68 class BookmarkModel : public KeyedService {
65 public: 69 public:
66 struct URLAndTitle { 70 struct URLAndTitle {
67 GURL url; 71 GURL url;
68 base::string16 title; 72 base::string16 title;
69 }; 73 };
70 74
71 explicit BookmarkModel(BookmarkClient* client); 75 explicit BookmarkModel(BookmarkClient* client);
72 ~BookmarkModel() override; 76 ~BookmarkModel() override;
73 77
78 // Register preferences.
79 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
tfarina 2015/07/10 17:30:52 By the way, I would do that separately, since it d
sdefresne 2015/07/16 07:23:33 Make sense, removed from this CL and will do in a
80
74 // KeyedService: 81 // KeyedService:
75 void Shutdown() override; 82 void Shutdown() override;
76 83
77 // Loads the bookmarks. This is called upon creation of the 84 // Loads the bookmarks. This is called upon creation of the
78 // BookmarkModel. You need not invoke this directly. 85 // BookmarkModel. You need not invoke this directly.
79 // All load operations will be executed on |io_task_runner| and the completion 86 // All load operations will be executed on |io_task_runner| and the completion
80 // callback will be called from |ui_task_runner|. 87 // callback will be called from |ui_task_runner|.
81 void Load(PrefService* pref_service, 88 void Load(PrefService* pref_service,
82 const std::string& accept_languages, 89 const std::string& accept_languages,
83 const base::FilePath& profile_path, 90 const base::FilePath& profile_path,
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 scoped_ptr<BookmarkExpandedStateTracker> expanded_state_tracker_; 455 scoped_ptr<BookmarkExpandedStateTracker> expanded_state_tracker_;
449 456
450 std::set<std::string> non_cloned_keys_; 457 std::set<std::string> non_cloned_keys_;
451 458
452 DISALLOW_COPY_AND_ASSIGN(BookmarkModel); 459 DISALLOW_COPY_AND_ASSIGN(BookmarkModel);
453 }; 460 };
454 461
455 } // namespace bookmarks 462 } // namespace bookmarks
456 463
457 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_ 464 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_MODEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698