Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1233663005: Cherry-pick a upstream patch for a data loading bug (Closed)

Created:
5 years, 5 months ago by jungshik at Google
Modified:
5 years, 5 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -30 lines) Patch
M README.chromium View 1 2 chunks +5 lines, -1 line 0 comments Download
A patches/dataload.patch View 1 chunk +152 lines, -0 lines 0 comments Download
M source/common/udata.cpp View 10 chunks +41 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jungshik at Google
PTAL. Thanks
5 years, 5 months ago (2015-07-16 21:50:45 UTC) #2
inferno
lgtm
5 years, 5 months ago (2015-07-16 21:53:20 UTC) #3
jungshik at Google
5 years, 5 months ago (2015-07-16 22:36:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
508e9274baaa5caa8de9cf4c26a24e926a15ccf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698