DescriptionInitialize render_frame_host_ in the constuctor of ServiceWorkerHandler.
The crash (crbug.com/508775) in ServiceWorkerHandler::UpdateHosts() seems to be caused by wrong state of render_frame_host_.
After ServiceWorkerHandler is created in the constructor of RenderFrameDevToolsAgentHost, ServiceWorkerHandler::SetRenderFrameHost() must be called before UpdateHosts() is called.
So render_frame_host_ must be set correctly before UpdateHosts() is called even if we are not initializing render_frame_host_ now.
So I think this change doesn't fix the crash.
But to make the code safe, we should initialize render_frame_host_ in the constructor.
BUG=508775
Committed: https://crrev.com/149f2315e7d239f66ab9e8635117b099c6976685
Cr-Commit-Position: refs/heads/master@{#338290}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|