Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1233633002: Initialize render_frame_host_ in the constuctor of ServiceWorkerHandler. (Closed)

Created:
5 years, 5 months ago by horo
Modified:
5 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, pfeldman, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize render_frame_host_ in the constuctor of ServiceWorkerHandler. The crash (crbug.com/508775) in ServiceWorkerHandler::UpdateHosts() seems to be caused by wrong state of render_frame_host_. After ServiceWorkerHandler is created in the constructor of RenderFrameDevToolsAgentHost, ServiceWorkerHandler::SetRenderFrameHost() must be called before UpdateHosts() is called. So render_frame_host_ must be set correctly before UpdateHosts() is called even if we are not initializing render_frame_host_ now. So I think this change doesn't fix the crash. But to make the code safe, we should initialize render_frame_host_ in the constructor. BUG=508775 Committed: https://crrev.com/149f2315e7d239f66ab9e8635117b099c6976685 Cr-Commit-Position: refs/heads/master@{#338290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/protocol/service_worker_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
pfeldman@ Could you please review this?
5 years, 5 months ago (2015-07-10 11:38:48 UTC) #2
dgozman
lgtm
5 years, 5 months ago (2015-07-10 12:22:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233633002/1
5 years, 5 months ago (2015-07-10 14:11:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 15:02:56 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 15:03:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/149f2315e7d239f66ab9e8635117b099c6976685
Cr-Commit-Position: refs/heads/master@{#338290}

Powered by Google App Engine
This is Rietveld 408576698