chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc - Issue 123363002: rAc: don't open sign in continue url in new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc

Issue 123363002: rAc: don't open sign in continue url in new tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no fake factory Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc b/chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc

index 877063376b656b66c2f39f715ed6a03d6d38f4f4..987a0a8ff83cfefb07db589302e8467eac02fc54 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc

@@ -21,8 +21,7 @@ using content::OpenURLParams;

// Signals if |params| require opening inside the current WebContents.

bool IsInPageTransition(const OpenURLParams& params) {

- return params.transition == content::PAGE_TRANSITION_LINK &&

Evan Stade 2014/01/03 01:47:44 new change

- params.disposition == CURRENT_TAB;

+ return params.disposition == CURRENT_TAB;

}

// Indicates if the open action specified by |params| should happen in the