Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1233623007: Provide some debug-mode time hooks to visually debug painting and layout. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Provide some debug-mode time hooks to visually debug painting and layout. There's four hooks: one draws a teal box around the size, one draws a green line and an orange line at the alphabetic and ideographic baselines, and one clips at the paintBounds. I also implemented Rect.shift() and Rect.inflate() to adjust Rects in various ways that were helpful while developing this. The baseline logic now lets you ask for the baseline _without_ the no-baseline adjustment, in case you only care about the baseline when there is a real one. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c5050c7b1d1648dc6f6e97b4a7ab463c85b67b20

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -11 lines) Patch
M sky/engine/core/painting/Rect.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/sdk/lib/base/debug.dart View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 2 chunks +48 lines, -10 lines 0 comments Download
M sky/sdk/lib/rendering/object.dart View 1 2 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-14 17:18:31 UTC) #2
Hixie
5 years, 5 months ago (2015-07-14 17:19:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c5050c7b1d1648dc6f6e97b4a7ab463c85b67b20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698