Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1233623004: MIPS: Check that branches to trampoline pool do actually reach. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips64/assembler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 // fixup_pos. 788 // fixup_pos.
789 Instr instr = instr_at(fixup_pos); 789 Instr instr = instr_at(fixup_pos);
790 if (is_internal) { 790 if (is_internal) {
791 target_at_put(fixup_pos, pos, is_internal); 791 target_at_put(fixup_pos, pos, is_internal);
792 } else if (!is_internal && IsBranch(instr)) { 792 } else if (!is_internal && IsBranch(instr)) {
793 if (dist > kMaxBranchOffset) { 793 if (dist > kMaxBranchOffset) {
794 if (trampoline_pos == kInvalidSlotPos) { 794 if (trampoline_pos == kInvalidSlotPos) {
795 trampoline_pos = get_trampoline_entry(fixup_pos); 795 trampoline_pos = get_trampoline_entry(fixup_pos);
796 CHECK(trampoline_pos != kInvalidSlotPos); 796 CHECK(trampoline_pos != kInvalidSlotPos);
797 } 797 }
798 DCHECK((trampoline_pos - fixup_pos) <= kMaxBranchOffset); 798 CHECK((trampoline_pos - fixup_pos) <= kMaxBranchOffset);
799 target_at_put(fixup_pos, trampoline_pos, false); 799 target_at_put(fixup_pos, trampoline_pos, false);
800 fixup_pos = trampoline_pos; 800 fixup_pos = trampoline_pos;
801 dist = pos - fixup_pos; 801 dist = pos - fixup_pos;
802 } 802 }
803 target_at_put(fixup_pos, pos, false); 803 target_at_put(fixup_pos, pos, false);
804 } else { 804 } else {
805 target_at_put(fixup_pos, pos, false); 805 target_at_put(fixup_pos, pos, false);
806 } 806 }
807 } 807 }
808 L->bind_to(pos); 808 L->bind_to(pos);
(...skipping 2284 matching lines...) Expand 10 before | Expand all | Expand 10 after
3093 if (patched) { 3093 if (patched) {
3094 CpuFeatures::FlushICache(pc + 2, sizeof(Address)); 3094 CpuFeatures::FlushICache(pc + 2, sizeof(Address));
3095 } 3095 }
3096 } 3096 }
3097 3097
3098 3098
3099 } // namespace internal 3099 } // namespace internal
3100 } // namespace v8 3100 } // namespace v8
3101 3101
3102 #endif // V8_TARGET_ARCH_MIPS 3102 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips64/assembler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698