Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 1233623004: MIPS: Check that branches to trampoline pool do actually reach. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Check that branches to trampoline pool do actually reach. Do the check in release mode, too. Prefer crash over mis-patched branch instruction. BUG=v8:4294 LOG=N Committed: https://crrev.com/91fcb0081e7aac6dfc4ea4831049069a3a89dafe Cr-Commit-Position: refs/heads/master@{#29581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
paul.l...
PTAL.
5 years, 5 months ago (2015-07-10 19:46:13 UTC) #2
balazs.kilvady
LGTM
5 years, 5 months ago (2015-07-10 19:47:55 UTC) #3
paul.l...
5 years, 5 months ago (2015-07-10 20:30:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233623004/1
5 years, 5 months ago (2015-07-10 20:30:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 20:55:41 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 20:55:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91fcb0081e7aac6dfc4ea4831049069a3a89dafe
Cr-Commit-Position: refs/heads/master@{#29581}

Powered by Google App Engine
This is Rietveld 408576698