Source/modules/fetch/FetchManager.cpp - Issue 1233573002: [Fetch API] Remove DrainingBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/fetch/FetchManager.cpp

Issue 1233573002: [Fetch API] Remove DrainingBuffer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/fetch/BodyStreamBufferTest.cpp ('K') | « Source/modules/fetch/BodyStreamBufferTest.cpp ('k') | Source/modules/fetch/FetchRequestData.cpp » ('j') | Source/modules/fetch/FetchRequestData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/fetch/FetchManager.cpp

diff --git a/Source/modules/fetch/FetchManager.cpp b/Source/modules/fetch/FetchManager.cpp

index e746bc53289498fa74207e17d4e5c6d82d427f3d..b9655dcd9ca7df1e0f77a3709bb2324571d7f911 100644

--- a/Source/modules/fetch/FetchManager.cpp

+++ b/Source/modules/fetch/FetchManager.cpp

@@ -121,7 +121,7 @@ void FetchManager::Loader::didReceiveResponse(unsigned long, const ResourceRespo

break;

}

- FetchResponseData* responseData = FetchResponseData::createWithBuffer(BodyStreamBuffer::create(createFetchDataConsumerHandleFromWebHandle(handle)));

+ FetchResponseData* responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(handle)));

responseData->setStatus(response.httpStatusCode());

responseData->setStatusMessage(response.httpStatusText());

for (auto& it : response.httpHeaderFields())

@@ -327,7 +327,7 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

if (m_request->method() != "GET" && m_request->method() != "HEAD") {

if (BodyStreamBuffer* buffer = m_request->buffer()) {

- RefPtr<BlobDataHandle> blobDataHandle = buffer->handle()->obtainReader(nullptr)->drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);

+ RefPtr<BlobDataHandle> blobDataHandle = buffer->drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);

RefPtr<FormData> httpBody(FormData::create());

if (blobDataHandle)

httpBody->appendBlob(blobDataHandle->uuid(), blobDataHandle);