Avoid race in isolate shutdown; add assertions, error messages

runtime/vm/thread.h

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_THREAD_H_
 #define VM_THREAD_H_
 
 #include "vm/globals.h"
 #include "vm/os_thread.h"
 #include "vm/store_buffer.h"
@@ skipping 57 matching lines @@
 
 #if defined(TARGET_OS_WINDOWS)
   // Clears the state of the current thread and frees the allocation.
   static void CleanUp();
 #endif
 
   // Called at VM startup.
   static void InitOnceBeforeIsolate();
   static void InitOnceAfterObjectAndStubCode();
 
+  ~Thread();
+
   // The topmost zone used for allocation in this thread.
   Zone* zone() const { return state_.zone; }
 
   // The isolate that this thread is operating on, or NULL if none.
   Isolate* isolate() const { return isolate_; }
   static intptr_t isolate_offset() {
     return OFFSET_OF(Thread, isolate_);
   }
 
   // The (topmost) CHA for the compilation in the isolate of this thread.
@@ skipping 77 matching lines @@
   void Unschedule();
 
   friend class Isolate;
   friend class StackZone;
   DISALLOW_COPY_AND_ASSIGN(Thread);
 };
 
 }  // namespace dart
 
 #endif  // VM_THREAD_H_