Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1233563003: Revert of [Telemetry] Remove adb_commands from android_browser_backend and android_browser_backend_setting (Closed)

Created:
5 years, 5 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Remove adb_commands from android_browser_backend and android_browser_backend_setting (patchset #3 id:40001 of https://codereview.chromium.org/1226373004/) Reason for revert: This patch broke the following perf bots: http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/3536/steps/memory.memory_health_plan/logs/stdio http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf/builds/1232/steps/memory.memory_health_plan/logs/stdio http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf/builds/4903/steps/memory.memory_health_plan/logs/stdio http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf/builds/467/steps/memory.memory_health_plan/logs/stdio http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/builds/1204/steps/memory.memory_health_plan/logs/stdio Original issue's description: > Re-land https://codereview.chromium.org/1213423003/ > The original patch has been uploaded in patch set 2 to make the diff clearer. > > Remove adb_commands from android_browser_backend and android_browser_backend_settings. > > Pulled from https://codereview.chromium.org/1167173002/ > > BUG=476709 > > Committed: https://crrev.com/6baec756afca1f9949f6ff0e0252dd070bb86349 > Cr-Commit-Position: refs/heads/master@{#338313} TBR=nednguyen@chromium.org,jbudorick@chromium.org,kbr@chromium.org,nednguyen@google.com,boliu@chromium.org,skyostil@chromium.org,navabi@chromium.org,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476709 Committed: https://crrev.com/6fc67a32a8cbcf1d8ecb0ebbf2c5a2fb4d80bb15 Cr-Commit-Position: refs/heads/master@{#338498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -120 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 16 chunks +22 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 6 chunks +25 lines, -60 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py View 5 chunks +19 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py View 7 chunks +20 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/android_forwarder.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
alex clarke (OOO till 29th)
5 years, 5 months ago (2015-07-13 11:31:31 UTC) #1
Created Revert of [Telemetry] Remove adb_commands from android_browser_backend
and android_browser_backend_setting

Powered by Google App Engine
This is Rietveld 408576698