Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1233553005: Fixes #254 - Better stacktrace support (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Added utilities to help debugging Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 4426755e2b6e30fb7962793d18e1c5b3c8606f7c..1eab31a1d0a5ac6acd9e24d86159018afcde097b 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -2322,9 +2322,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
visitThrowExpression(ThrowExpression node) {
var expr = _visit(node.expression);
if (node.parent is ExpressionStatement) {
- return js.statement('throw #;', expr);
+ return js.statement('dart.throw(#);', expr);
} else {
- return js.call('dart.throw_(#)', expr);
+ return js.call('dart.throw(#)', expr);
}
}
@@ -2333,7 +2333,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
if (node.parent is ExpressionStatement) {
return js.statement('throw #;', _visit(_catchParameter));
} else {
- return js.call('dart.throw_(#)', _visit(_catchParameter));
+ return js.call('throw #', _visit(_catchParameter));
}
}
@@ -2599,7 +2599,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
_unimplementedCall('Unimplemented ${node.runtimeType}: $node');
JS.Expression _unimplementedCall(String comment) {
- return js.call('dart.throw_(#)', [js.escapedString(comment)]);
+ return js.call('dart.throw(#)', [js.escapedString(comment)]);
Jennifer Messerly 2015/07/14 18:30:33 not related to your CL but: maybe we should throw
}
@override

Powered by Google App Engine
This is Rietveld 408576698