Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: lib/runtime/dart/isolate.js

Issue 1233553005: Fixes #254 - Better stacktrace support (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: format fix Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/isolate.js
diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js
index 8eadbb8d7300c9d3e505f635f875cd032cd5a967..d625ecb66afead486c0f6e13793f8eafa852c029 100644
--- a/lib/runtime/dart/isolate.js
+++ b/lib/runtime/dart/isolate.js
@@ -53,16 +53,16 @@ dart_library.library('dart/isolate', null, /* Imports */[
let paused = opts && 'paused' in opts ? opts.paused : false;
let packageRoot = opts && 'packageRoot' in opts ? opts.packageRoot : null;
if (packageRoot != null)
- throw new core.UnimplementedError("packageRoot");
+ dart.throw(new core.UnimplementedError("packageRoot"));
try {
if (dart.is(args, core.List)) {
for (let i = 0; dart.notNull(i) < dart.notNull(args[dartx.length]); i = dart.notNull(i) + 1) {
if (!(typeof args[dartx.get](i) == 'string')) {
- throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
+ dart.throw(new core.ArgumentError(`Args must be a list of Strings ${args}`));
}
}
} else if (args != null) {
- throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
+ dart.throw(new core.ArgumentError(`Args must be a list of Strings ${args}`));
}
return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [dart.dynamic])), async.Future$(Isolate));
} catch (e) {
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698