Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: lib/runtime/_operations.js

Issue 1233553005: Fixes #254 - Better stacktrace support (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/_interceptors.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/_operations.js
diff --git a/lib/runtime/_operations.js b/lib/runtime/_operations.js
index 6f9294edfe6a23ecfbcd9e8454f66cec48ac1458..f6012f42c6981e1aaac137ba48fcfbad006c9ed1 100644
--- a/lib/runtime/_operations.js
+++ b/lib/runtime/_operations.js
@@ -269,12 +269,22 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
}
exports.assert = assert;
- function throw_(obj) { throw obj; }
+ let _stack = Symbol('_stack');
+
+ function throw_(obj) {
+ obj[_stack] = new Error();
+ throw obj;
+ }
exports.throw_ = throw_;
Jennifer Messerly 2015/07/13 16:39:17 btw, this should be `throw` ... all names work for
vsm 2015/07/14 13:54:48 Done.
+ function rethrow(obj) {
Jennifer Messerly 2015/07/13 16:39:17 if this doesn't do anything, why have the helper?
vsm 2015/07/14 13:54:48 Removed
+ throw obj;
+ }
+ exports.rethrow = rethrow;
function stackTrace(exception) {
- return _js_helper.getTraceFromException(exception);
+ var error = _stack in exception ? exception[_stack] : exception;
+ return _js_helper.getTraceFromException(error);
}
exports.stackTrace = stackTrace;
« no previous file with comments | « no previous file | lib/runtime/dart/_interceptors.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698