Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: runtime/vm/object.cc

Issue 12335146: - Do not use the ? operator in the List factory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intrinsifier.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/bigint_operations.h" 10 #include "vm/bigint_operations.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 119
120 const double MegamorphicCache::kLoadFactor = 0.75; 120 const double MegamorphicCache::kLoadFactor = 0.75;
121 121
122 122
123 // The following functions are marked as invisible, meaning they will be hidden 123 // The following functions are marked as invisible, meaning they will be hidden
124 // in the stack trace. 124 // in the stack trace.
125 // (Library, class name, method name) 125 // (Library, class name, method name)
126 #define INVISIBLE_LIST(V) \ 126 #define INVISIBLE_LIST(V) \
127 V(CoreLibrary, Object, _noSuchMethod) \ 127 V(CoreLibrary, Object, _noSuchMethod) \
128 V(CoreLibrary, List, _throwArgumentError) \ 128 V(CoreLibrary, _ObjectArray, _ObjectArray.) \
129 V(CoreLibrary, AssertionErrorImplementation, _throwNew) \ 129 V(CoreLibrary, AssertionErrorImplementation, _throwNew) \
130 V(CoreLibrary, TypeErrorImplementation, _throwNew) \ 130 V(CoreLibrary, TypeErrorImplementation, _throwNew) \
131 V(CoreLibrary, FallThroughErrorImplementation, _throwNew) \ 131 V(CoreLibrary, FallThroughErrorImplementation, _throwNew) \
132 V(CoreLibrary, AbstractClassInstantiationErrorImplementation, _throwNew) \ 132 V(CoreLibrary, AbstractClassInstantiationErrorImplementation, _throwNew) \
133 V(CoreLibrary, NoSuchMethodError, _throwNew) \ 133 V(CoreLibrary, NoSuchMethodError, _throwNew) \
134 V(CoreLibrary, int, _throwFormatException) \ 134 V(CoreLibrary, int, _throwFormatException) \
135 V(CoreLibrary, int, _parse) \ 135 V(CoreLibrary, int, _parse) \
136 136
137 137
138 static void MarkFunctionAsInvisible(const Library& lib, 138 static void MarkFunctionAsInvisible(const Library& lib,
139 const char* class_name, 139 const char* class_name,
140 const char* function_name) { 140 const char* function_name) {
141 ASSERT(!lib.IsNull()); 141 ASSERT(!lib.IsNull());
142 const Class& cls = Class::Handle( 142 const Class& cls = Class::Handle(
143 lib.LookupClass(String::Handle(String::New(class_name)))); 143 lib.LookupClassAllowPrivate(String::Handle(String::New(class_name))));
144 ASSERT(!cls.IsNull()); 144 ASSERT(!cls.IsNull());
145 const Function& function = 145 const Function& function =
146 Function::Handle( 146 Function::Handle(
147 cls.LookupFunctionAllowPrivate( 147 cls.LookupFunctionAllowPrivate(
148 String::Handle(String::New(function_name)))); 148 String::Handle(String::New(function_name))));
149 ASSERT(!function.IsNull()); 149 ASSERT(!function.IsNull());
150 function.set_is_visible(false); 150 function.set_is_visible(false);
151 } 151 }
152 152
153 153
(...skipping 12952 matching lines...) Expand 10 before | Expand all | Expand 10 after
13106 } 13106 }
13107 return result.raw(); 13107 return result.raw();
13108 } 13108 }
13109 13109
13110 13110
13111 const char* WeakProperty::ToCString() const { 13111 const char* WeakProperty::ToCString() const {
13112 return "_WeakProperty"; 13112 return "_WeakProperty";
13113 } 13113 }
13114 13114
13115 } // namespace dart 13115 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698