Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/mjsunit/regress/regress-crbug-163530.js

Issue 12335132: Fix materialization of arguments objects with unknown values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax 28 // Flags: --allow-natives-syntax
29 29
30 // Test usage of static type information for loads that would otherwise 30 // Test materialization of an arguments object with unknown argument
31 // turn into polymorphic or generic loads. 31 // values in non-strict mode (length has to be zero).
32 (function() {
33 var deoptimize = { deopt:true };
34 var object = {};
32 35
33 // Prepare a highly polymorphic load to be used by all tests. 36 object.a = function A(x, y, z) {
34 Object.prototype.load = function() { return this.property; }; 37 assertSame(0, arguments.length);
35 Object.prototype.load.call({ A:0, property:10 }); 38 return this.b();
36 Object.prototype.load.call({ A:0, B:0, property:11 }); 39 };
37 Object.prototype.load.call({ A:0, B:0, C:0, property:12 });
38 Object.prototype.load.call({ A:0, B:0, C:0, D:0, property:13 });
39 Object.prototype.load.call({ A:0, B:0, C:0, D:0, E:0, property:14 });
40 Object.prototype.load.call({ A:0, B:0, C:0, D:0, E:0, F:0, property:15 });
41 40
42 // Test for object literals. 41 object.b = function B() {
43 (function() { 42 assertSame(0, arguments.length);
44 function f(x) { 43 deoptimize.deopt;
45 var object = { property:x }; 44 return arguments.length;
46 return object.load(); 45 };
47 }
48 46
49 assertSame(1, f(1)); 47 assertSame(0, object.a());
50 assertSame(2, f(2)); 48 assertSame(0, object.a());
51 %OptimizeFunctionOnNextCall(f); 49 %OptimizeFunctionOnNextCall(object.a);
52 assertSame(3, f(3)); 50 assertSame(0, object.a());
51 delete deoptimize.deopt;
52 assertSame(0, object.a());
53 })(); 53 })();
54 54
55 // Test for inlined constructors. 55
56 // Test materialization of an arguments object with unknown argument
57 // values in strict mode (length is allowed to exceed stack size).
56 (function() { 58 (function() {
57 function c(x) { 59 'use strict';
58 this.property = x; 60 var deoptimize = { deopt:true };
59 } 61 var object = {};
60 function f(x) {
61 var object = new c(x);
62 return object.load();
63 }
64 62
65 assertSame(1, f(1)); 63 object.a = function A(x, y, z) {
66 assertSame(2, f(2)); 64 assertSame(0, arguments.length);
67 %OptimizeFunctionOnNextCall(f); 65 return this.b(1, 2, 3, 4, 5, 6, 7, 8);
68 assertSame(3, f(3)); 66 };
67
68 object.b = function B(a, b, c, d, e, f, g, h) {
69 assertSame(8, arguments.length);
70 deoptimize.deopt;
71 return arguments.length;
72 };
73
74 assertSame(8, object.a());
75 assertSame(8, object.a());
76 %OptimizeFunctionOnNextCall(object.a);
77 assertSame(8, object.a());
78 delete deoptimize.deopt;
79 assertSame(8, object.a());
69 })(); 80 })();
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698