Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12335132: Fix materialization of arguments objects with unknown values. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix materialization of arguments objects with unknown values. This fixes the deoptimizer to materialize arguments objects of correct length even in cases where the actual argument values are unknown and were optimized away by Crankshaft. This can happen if only the length property or the identity of an arguments object is used. R=svenpanne@chromium.org BUG=chromium:163530 TEST=mjsunit/regress/regress-crbug-163530 Committed: http://code.google.com/p/v8/source/detail?r=13763

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ported to x64 and ARM. #

Patch Set 3 : Addressed comments by Sven Panne. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -101 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 7 chunks +32 lines, -20 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 6 chunks +12 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 7 chunks +32 lines, -20 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 7 chunks +32 lines, -20 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-163530.js View 1 2 1 chunk +43 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-02-27 13:49:17 UTC) #1
Sven Panne
LGTM with a nit. General note: AddToTranslation's signature with 3 bools and 2 ints is ...
7 years, 9 months ago (2013-02-27 14:27:23 UTC) #2
Michael Starzinger
Addressed comments. Landing. I agree that the signature of AddToTranslation() is getting complex and hard ...
7 years, 9 months ago (2013-02-27 14:34:01 UTC) #3
Michael Starzinger
7 years, 9 months ago (2013-02-27 14:38:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r13763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698