samples/third_party/dromaeo/Suites.dart - Issue 12335131: Make List.from default to not growable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/Suites.dart

Issue 12335131: Make List.from default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix one more from. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/third_party/dromaeo/Suites.dart

diff --git a/samples/third_party/dromaeo/Suites.dart b/samples/third_party/dromaeo/Suites.dart

index 4bb553d97efa67fa982b414669b74e3f70927c91..cf5ea49204b928f2917d5649c53ee1d4ecb46bae 100644

--- a/samples/third_party/dromaeo/Suites.dart

+++ b/samples/third_party/dromaeo/Suites.dart

@@ -113,7 +113,7 @@ class Suites {

List<String> libraries = variant[1];

for(String lib in libraries) {

String path = _getHtmlPathForVariant(platform, lib, suite.file);

- final combined = new List.from(suite.tags);

+ final combined = new List.from(suite.tags, growable: true);

combined.add(platform);

if (lib != '') {

combined.add(lib);