Handle shared path dependencies.

utils/pub/path_source.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library path_source;
 
 import 'dart:async';
 import 'dart:io';
 
 import '../../pkg/pathos/lib/path.dart' as path;
 
+import 'log.dart' as log;
+
 import 'io.dart';
 import 'package.dart';
 import 'pubspec.dart';
 import 'version.dart';
 import 'source.dart';
 import 'utils.dart';
 
 // TODO(rnystrom): Support relative paths. (See comment in _validatePath().)
 /// A package [Source] that installs packages from a given local file path.
 class PathSource extends Source {
   final name = 'path';
   final shouldCache = false;
 
   Future<Pubspec> describe(PackageId id) {
     return defer(() {
       _validatePath(id.name, id.description);
       return new Pubspec.load(id.name, id.description["path"],
           systemCache.sources);
     });
   }
 
+  bool descriptionsEqual(description1, description2) {
+    // TODO(rnystrom): Traverse symlinks and compare real paths?

[nweiz, 2013/02/25 22:08:46]

I'm leaning towards yes.

[Bob Nystrom, 2013/02/25 22:50:26]

Done.

+    var path1 = path.normalize(description1["path"]);
+    var path2 = path.normalize(description2["path"]);
+    return path1 == path2 &&
+        description1["relative"] == description2["relative"];

[nweiz, 2013/02/25 22:08:46]

I don't think this is correct. If both paths resolve to the same location,
they're always pointing to the same package, regardless if one is relative and
the other isn't.

[Bob Nystrom, 2013/02/25 22:50:26]

Done.

+  }
+
   Future<bool> install(PackageId id, String destination) {
     return defer(() {
       try {
         _validatePath(id.name, id.description);
       } on FormatException catch(err) {
         return false;
       }
 
       return createPackageSymlink(id.name, id.description["path"], destination,
           relative: id.description["relative"]);
     }).then((_) => true);
   }
 
   /// Parses a path dependency. This takes in a path string and returns a map.
-  /// The "path" key will be the original path but resolves relative to the
+  /// The "path" key will be the original path but resolved relative to the
   /// containing path. The "relative" key will be `true` if the original path
   /// was relative.
   ///
   /// A path coming from a pubspec is a simple string. From a lock file, it's
   /// an expanded {"path": ..., "relative": ...} map.
   dynamic parseDescription(String containingPath, description,
                            {bool fromLockFile: false}) {
     if (fromLockFile) {
       if (description is! Map) {
         throw new FormatException("The description must be a map.");
@@ skipping 43 matching lines @@
       throw new FormatException(
           "Path dependency for package '$name' must refer to a "
           "directory, not a file. Was '$dir'.");
     }
 
     if (!dirExists(dir)) {
       throw new FormatException("Could not find package '$name' at '$dir'.");
     }
   }
 }