Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 12335073: Use EmptyPlatform in Browser ctor. (Closed)

Created:
7 years, 10 months ago by achuithb
Modified:
7 years, 10 months ago
Reviewers:
bulach, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Use EmptyPlatform in Browser ctor. BUG= TEST=./run_tests --browser=cros-chrome --remote=<ip> works NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/chrome/cros_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Fallout from https://chromiumcodereview.appspot.com/11428107
7 years, 10 months ago (2013-02-25 21:25:17 UTC) #1
nduca
lgtm
7 years, 10 months ago (2013-02-25 21:38:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/12335073/1
7 years, 10 months ago (2013-02-25 21:41:24 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-25 21:52:10 UTC) #4
Message was sent while issue was closed.
Change committed as 184489

Powered by Google App Engine
This is Rietveld 408576698