Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1233503003: Remove the :-webkit-full-screen-document pseudo class (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the :-webkit-full-screen-document pseudo class It is virtually unused in the wild, according to use counter data: https://www.chromestatus.com/metrics/feature/timeline/popularity/627 Nothing similar exists in the spec or is likely to ever be added. BUG=402378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M LayoutTests/fast/css/invalidation/fullscreen.html View 3 chunks +2 lines, -13 lines 0 comments Download
M LayoutTests/fast/css/invalidation/fullscreen-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-css.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-css-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M ManualTests/fullscreen/full-screen-flash.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233503003/1
5 years, 5 months ago (2015-07-13 12:45:43 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-13 14:05:59 UTC) #4
philipj_slow
falken, PTAL. I think this is trivial enough to bypass the intent process, but if ...
5 years, 5 months ago (2015-07-13 14:35:11 UTC) #6
falken
On 2015/07/13 14:35:11, philipj wrote: > falken, PTAL. I think this is trivial enough to ...
5 years, 5 months ago (2015-07-15 09:40:29 UTC) #7
philipj_slow
Jochen, API owners sanity check please?
5 years, 5 months ago (2015-07-15 10:22:58 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-15 14:06:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233503003/1
5 years, 5 months ago (2015-07-15 14:10:12 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 15:38:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198966

Powered by Google App Engine
This is Rietveld 408576698