Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 12335026: Add GetDefaultIndex() to ComboboxModel. (Closed)

Created:
7 years, 10 months ago by Evan Stade
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Visibility:
Public.

Description

Add GetDefaultIndex() to ComboboxModel. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184532

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add missing file #

Patch Set 4 : fix linux #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 1

Patch Set 8 : UI_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/models/combobox_model.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
A + ui/base/models/combobox_model.cc View 1 2 6 1 chunk +4 lines, -2 lines 0 comments Download
M ui/ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
7 years, 10 months ago (2013-02-22 01:58:47 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-22 05:57:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12335026/10002
7 years, 10 months ago (2013-02-22 21:08:59 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-22 22:04:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12335026/14003
7 years, 10 months ago (2013-02-22 22:07:54 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-22 22:36:25 UTC) #6
Evan Stade
Scott, do you have any idea why this is failing on clang trybots? It works ...
7 years, 10 months ago (2013-02-25 23:54:19 UTC) #7
tfarina
I think the following should fix it. It wasn't necessary because everything was in the ...
7 years, 10 months ago (2013-02-26 00:00:03 UTC) #8
Evan Stade
thank you, I feel dumb. I figured out I needed the ui_export.h include but somehow ...
7 years, 10 months ago (2013-02-26 00:03:44 UTC) #9
Evan Stade
7 years, 10 months ago (2013-02-26 00:51:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #8 manually as r184532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698