[Spellcheck] Add UMA stat for SpellingService

chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 106 matching lines @@
     Histogram* histogram =
         StatisticsRecorder::FindHistogram(histogramName[i]);
     ASSERT_TRUE(histogram != NULL);
     samples[i] = histogram->SnapshotSamples();
     if (baselines[i].get())
       samples[i]->Subtract(*baselines[i]);
 
     EXPECT_EQ(0, samples[i]->TotalCount());
   }
 }
+
+TEST_F(SpellcheckHostMetricsTest, RecordSpellingServiceStats) {
+  const char kMetricName[] = "SpellCheck.SpellingService.Enabled";
+  scoped_ptr<HistogramSamples> baseline;
+  Histogram* histogram =
+      StatisticsRecorder::FindHistogram(kMetricName);
+  if (histogram)

[rpetterson, 2013/02/21 22:01:06]

When would this not be here? Or rather, why use "if" as opposed to ASSERT?

[groby-ooo-7-16, 2013/02/22 04:32:29]

If no counts for this histogram have been recorded yet, histogram will be NULL.
This happens _only_ if this is the very first test accessing the stat.
Unfortunately, histogram state can't be easily reset and survives until the
process gets shut down.  If _any_ other unit tests added to that histogram, we
get a non-NULL pointer.

That means both cases are valid, hence no ASSERT.

+    baseline = histogram->SnapshotSamples();
+
+  metrics()->RecordSpellingServiceStats(false);
+
+  histogram =
+      StatisticsRecorder::FindHistogram(kMetricName);
+  ASSERT_TRUE(histogram != NULL);
+  scoped_ptr<HistogramSamples> samples(histogram->SnapshotSamples());
+  if (baseline.get())
+    samples->Subtract(*baseline);
+  EXPECT_EQ(1, samples->GetCount(0));
+  EXPECT_EQ(0, samples->GetCount(1));
+
+  baseline.reset(samples.release());
+
+  metrics()->RecordSpellingServiceStats(true);
+
+  histogram =
+      StatisticsRecorder::FindHistogram(kMetricName);
+  ASSERT_TRUE(histogram != NULL);
+  samples = histogram->SnapshotSamples();
+  samples->Subtract(*baseline);
+  EXPECT_EQ(0, samples->GetCount(0));
+  EXPECT_EQ(1, samples->GetCount(1));
+}