Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 12335018: ninja: Pass -rpath-link when passing -rpath. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: Pass -rpath-link when passing -rpath. Gold works fine without -rpath-link, but GNU ld needs it. The make generator already does this. To quote the previous make generator CL: "it appears that ld.bfd is not $ORIGIN-aware and needs additional information to figure out where to find shared libraries that shared libraries depend on" Committed: https://code.google.com/p/gyp/source/detail?r=1580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Gold works fine without this, but GNU ld needs it. The make generator already does ...
7 years, 10 months ago (2013-02-21 21:42:49 UTC) #1
Evan Martin
reviewer pet peeve nit: can you put the "why" (what you wrote in your message) ...
7 years, 10 months ago (2013-02-21 21:47:21 UTC) #2
Lei Zhang
On 2013/02/21 21:47:21, Evan Martin wrote: > reviewer pet peeve nit: can you put the ...
7 years, 10 months ago (2013-02-21 21:51:43 UTC) #3
Evan Martin
LGTM
7 years, 10 months ago (2013-02-21 22:01:21 UTC) #4
Dirk Pranke
lgtm as well.
7 years, 10 months ago (2013-02-21 22:29:32 UTC) #5
Lei Zhang
7 years, 10 months ago (2013-02-21 22:40:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r1580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698