Issue 1233493008: Generate Sky's _sdkext file using the build system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233493008: Generate Sky's _sdkext file using the build system (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, eseidel1

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Generate Sky's _sdkext file using the build system This CL removes sky/sdk/lib/_sdkext from the source tree so that we can have a tweaked version during development. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/4ad41e4b2d336ee9fd4041c3e21143a46f9c6ebf

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -11 lines)			Patch
M	mojo/public/dart/rules.gni	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	mojo/public/tools/dart_pkg.py	View	4 chunks	+29 lines, -2 lines	0 comments	Download
M	sky/sdk/.gitignore	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View	2 chunks	+5 lines, -1 line	0 comments	Download
D	sky/sdk/lib/_sdkext	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-10 20:04:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ad41e4b2d336ee9fd4041c3e21143a46f9c6ebf (presubmit successful).

Expand Messages | Collapse Messages