Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1233493007: Update the context if Set on slow-mode argument targets an aliased arguments entry (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update the context if Set on slow-mode argument targets an aliased arguments entry BUG=v8:4177 LOG=n Committed: https://crrev.com/377ea534703c5c9bffd407bd8d6d22177bba225f Cr-Commit-Position: refs/heads/master@{#29575}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M src/elements.cc View 4 chunks +25 lines, -7 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -14 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-10 13:45:23 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-10 13:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233493007/1
5 years, 5 months ago (2015-07-10 13:53:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233493007/1
5 years, 5 months ago (2015-07-10 15:11:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 15:52:03 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/377ea534703c5c9bffd407bd8d6d22177bba225f Cr-Commit-Position: refs/heads/master@{#29575}
5 years, 5 months ago (2015-07-10 15:52:20 UTC) #10
arv (Not doing code reviews)
5 years, 5 months ago (2015-07-10 15:54:48 UTC) #12
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/1233493007/diff/1/test/test262-es6/test262-es...
File test/test262-es6/test262-es6.status (left):

https://codereview.chromium.org/1233493007/diff/1/test/test262-es6/test262-es...
test/test262-es6/test262-es6.status:508: #
https://code.google.com/p/v8/issues/detail?id=4177
Woot!

Powered by Google App Engine
This is Rietveld 408576698