Issue 1233463002: Ban dart:mirrors in Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233463002: Ban dart:mirrors in Sky (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Ban dart:mirrors in Sky We don't use dart:mirrors and we don't want to start because it prevents some sorts of static analysis. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/be8ba94eaf483d60238ef26f9af017d3f1c74514

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -25 lines)			Patch
M	sky/engine/core/script/dart_init.cc	View	2 chunks	+9 lines, -15 lines	0 comments	Download
M	sky/sdk/lib/widgets/tabs.dart	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/tools/packager/vm.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-09 21:07:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be8ba94eaf483d60238ef26f9af017d3f1c74514 (presubmit successful).